[Test Fix] Fix Consecutive oneshot #971
Merged
+146
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. |
Author
|
/ready |
dsikka
requested changes
Jan 10, 2025
rahul-tuli
reviewed
Jan 10, 2025
Collaborator
rahul-tuli
left a comment
rahul-tuli
left a comment
There was a problem hiding this comment.
Looks fine, I feel we can make a few functions cleaner by using pathlib. But I'll leave that upto you
…-compressor into fix-test-conseq-oneshot
rahul-tuli
previously approved these changes
Jan 20, 2025
kylesayrs
requested changes
Jan 20, 2025
Collaborator
kylesayrs
left a comment
kylesayrs
left a comment
There was a problem hiding this comment.
I believe the purpose of this test to test consecutive runs without model reloading.
There are quite a few helper functions which I'm not entirely convinced are needed as of now. I think it might be worth revisiting whether they're actually needed for these tests
kylesayrs
previously approved these changes
Jan 22, 2025
added 2 commits
January 22, 2025 16:12
…-compressor into fix-test-conseq-oneshot
dsikka
reviewed
Jan 22, 2025
dsikka
requested changes
Jan 22, 2025
added 2 commits
January 22, 2025 16:39
…-compressor into fix-test-conseq-oneshot
dsikka
reviewed
Jan 22, 2025
kylesayrs
previously approved these changes
Jan 22, 2025
dsikka
reviewed
Jan 23, 2025
added 5 commits
January 23, 2025 11:10
…-compressor into fix-test-conseq-oneshot
rahul-tuli
added a commit
that referenced
this pull request
Jan 28, 2025
~~Contingent on merge of huggingface/transformers#34719 ~~ ^ has been merged not yet released ~~ ^ has been released Blocked on vllm-project/compressed-tensors#237 SUMMARY: * In multiple optimization tests, automatically decompress model if provided as optimized model * Fix recipe stage length * Revive old code * When running multiple optimizations (ex. oneshot then finetune, oneshot and oneshot), the recipes needs to be added to the session using `initialize_recipe`. Example here https://github.com/vllm-project/llm-compressor/pull/971/files#diff-c9ae8b3ad24d13abeea5b649a5fd6d0b0925f5c9cc40220cbfbe21ae81242f8dR63-R65 TEST PLAN: ran the test using transformers main Must pass tests/llmcompressor/transformers/obcq/test_consecutive_runs.py --------- Co-authored-by: Dipika Sikka <[email protected]> Co-authored-by: Rahul Tuli <[email protected]> Signed-off-by: Rahul Tuli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contingent on merge of huggingface/transformers#34719~~ ^ has been merged not yet released ~~
^ has been released
Blocked on
vllm-project/compressed-tensors#237
SUMMARY:
initialize_recipe. Example here https://github.com/vllm-project/llm-compressor/pull/971/files#diff-c9ae8b3ad24d13abeea5b649a5fd6d0b0925f5c9cc40220cbfbe21ae81242f8dR63-R65TEST PLAN:
ran the test using transformers main
Must pass tests/llmcompressor/transformers/obcq/test_consecutive_runs.py